Skip to content

Conversation

@GUIDINGLI
Copy link
Contributor

Summary

uinput: fix uinput compile failed, if no define CONFIG_UINPUT_TOUCH

input/uinput.c:81:28: error: field 'lower' has incomplete type
81 | struct touch_lowerhalf_s lower;
| ^~~~~

Impact

uinput

Testing

VELA

input/uinput.c:81:28: error: field 'lower' has incomplete type
   81 |   struct touch_lowerhalf_s lower;
      |                            ^~~~~
CC:  pipes/pipe.c

Signed-off-by: ligd <liguiding1@xiaomi.com>
@acassis
Copy link
Contributor

acassis commented Jan 16, 2023

@GUIDINGLI seems like it is failing because some issues on someone else included code:

In file included from chip/sam_clockconfig.c:34:
chip/sam_clockconfig.c: In function 'sam_usbclockconfig':
Error: /github/workspace/sources/nuttx/arch/arm/src/common/arm_internal.h:135:51: error: 'regval' is used uninitialized [-Werror=uninitialized]
  135 | #define putreg32(v,a)  (*(volatile uint32_t *)(a) = (v))
      |                                                   ^
chip/sam_clockconfig.c:422:12: note: 'regval' was declared here
  422 |   uint32_t regval;
      |            ^~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:144: sam_clockconfig.o] Error 1
make[1]: Target 'libarch.a' not remade because of errors.
make: *** [tools/LibTargets.mk:158: arch/arm/src/libarch.a] Error 2
make: Target 'all' not remade because of errors.

@xiaoxiang781216
Copy link
Contributor

Let's ignore the unrelated ci broken which is fixed by #8155.

@xiaoxiang781216 xiaoxiang781216 merged commit 354abd4 into apache:master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants