driver/pty: Map CR->LF from terminal input#8667
Merged
xiaoxiang781216 merged 1 commit intoapache:masterfrom Feb 27, 2023
Merged
driver/pty: Map CR->LF from terminal input#8667xiaoxiang781216 merged 1 commit intoapache:masterfrom
xiaoxiang781216 merged 1 commit intoapache:masterfrom
Conversation
NuttX only treat \n as new line after apache#8628, so need this conversion to interact with terminal emulator. Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
xiaoxiang781216
approved these changes
Feb 27, 2023
jerpelea
approved these changes
Feb 27, 2023
xiaoxiang781216
approved these changes
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NuttX only treat \n as new line after #8628, so need this conversion to interact with terminal emulator.
The default configuration is suitable for adb like usage (master connected to external terminal emulator, slave connected to nsh).
For other usage that need transparent data stream, need to call termios to make the pty works in raw mode.
Impact
pty driver
Testing
adb and telnetd shell