Skip to content

feat(services/gcs): Add batch delete support#2142

Merged
Xuanwo merged 12 commits intoapache:mainfrom
wcy-fdu:gcs_batch_delete
Jun 8, 2023
Merged

feat(services/gcs): Add batch delete support#2142
Xuanwo merged 12 commits intoapache:mainfrom
wcy-fdu:gcs_batch_delete

Conversation

@wcy-fdu
Copy link
Copy Markdown
Contributor

@wcy-fdu wcy-fdu commented Apr 27, 2023

Via batch api

@suyanhanx
Copy link
Copy Markdown
Member

Could update onto the base branch?

Comment thread core/src/services/gcs/backend.rs Outdated
Comment thread core/src/services/gcs/core.rs Outdated
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Apr 27, 2023

Tests failed for:

[2023-04-27T14:01:47Z ERROR opendal::services] service=gcs operation=batch-delete count=3 -> failed: Unexpected (permanent) at batch => signing http request
    
    Context:
        called: reqsign::Sign
        service: gcs
    
    Source: request without authority is invalid for signing
    
Error: Unexpected (persistent) at batch, context: { called: reqsign::Sign, service: gcs } => signing http request, source: request without authority is invalid for signing

Caused by:
    request without authority is invalid for signing


failures:
    services_gcs::list_test_remove_all

Comment thread core/src/services/gcs/core.rs Outdated
@wcy-fdu
Copy link
Copy Markdown
Contributor Author

wcy-fdu commented Apr 27, 2023

Tests failed for:

[2023-04-27T14:01:47Z ERROR opendal::services] service=gcs operation=batch-delete count=3 -> failed: Unexpected (permanent) at batch => signing http request
    
    Context:
        called: reqsign::Sign
        service: gcs
    
    Source: request without authority is invalid for signing
    
Error: Unexpected (persistent) at batch, context: { called: reqsign::Sign, service: gcs } => signing http request, source: request without authority is invalid for signing

Caused by:
    request without authority is invalid for signing


failures:
    services_gcs::list_test_remove_all

Tests failed for:

[2023-04-27T14:01:47Z ERROR opendal::services] service=gcs operation=batch-delete count=3 -> failed: Unexpected (permanent) at batch => signing http request
    
    Context:
        called: reqsign::Sign
        service: gcs
    
    Source: request without authority is invalid for signing
    
Error: Unexpected (persistent) at batch, context: { called: reqsign::Sign, service: gcs } => signing http request, source: request without authority is invalid for signing

Caused by:
    request without authority is invalid for signing


failures:
    services_gcs::list_test_remove_all

Please try again, thanks.

wcy-fdu and others added 3 commits April 27, 2023 22:18
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Apr 27, 2023

The returning response is also a multipart instead json. Maybe we should implement the multipart-mixed request and response feature in http_util frist.

Wait for #2152

@Xuanwo Xuanwo marked this pull request as draft April 27, 2023 14:57
@wcy-fdu
Copy link
Copy Markdown
Contributor Author

wcy-fdu commented Apr 28, 2023

The returning response is also a multipart instead json. Maybe we should implement the multipart-mixed request and response feature in http_util frist.

Wait for #2152

Feel free to close this PR, I will fix the response as multipart after #2152 implemented.

@suyanhanx
Copy link
Copy Markdown
Member

The returning response is also a multipart instead json. Maybe we should implement the multipart-mixed request and response feature in http_util frist.

Wait for #2152

Feel free to close this PR, I will fix the response as multipart after #2152 implemented.

👀Just keep as draft. Don't worry.

Xuanwo added 3 commits June 8, 2023 07:32
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo changed the title feat(services/gcs): support batch delete for gcs feat(services/gcs): Add batch delete support Jun 8, 2023
@Xuanwo Xuanwo marked this pull request as ready for review June 8, 2023 00:22
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jun 8, 2023
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit ab9f0a8 into apache:main Jun 8, 2023
@PsiACE PsiACE mentioned this pull request Jun 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants