feat(services/gcs): Add batch delete support#2142
Merged
Xuanwo merged 12 commits intoapache:mainfrom Jun 8, 2023
Merged
Conversation
Member
|
Could update onto the base branch? |
Xuanwo
reviewed
Apr 27, 2023
Member
|
Tests failed for: [2023-04-27T14:01:47Z ERROR opendal::services] service=gcs operation=batch-delete count=3 -> failed: Unexpected (permanent) at batch => signing http request
Context:
called: reqsign::Sign
service: gcs
Source: request without authority is invalid for signing
Error: Unexpected (persistent) at batch, context: { called: reqsign::Sign, service: gcs } => signing http request, source: request without authority is invalid for signing
Caused by:
request without authority is invalid for signing
failures:
services_gcs::list_test_remove_all |
Xuanwo
reviewed
Apr 27, 2023
Contributor
Author
Please try again, thanks. |
Signed-off-by: Xuanwo <github@xuanwo.io>
Member
|
The returning response is also a multipart instead json. Maybe we should implement the multipart-mixed request and response feature in Wait for #2152 |
Contributor
Author
Member
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo
approved these changes
Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Via batch api