Skip to content

refactor(java): refactor java code for java binding#2145

Merged
Xuanwo merged 5 commits intoapache:mainfrom
ShadowySpirits:java_binding
Apr 29, 2023
Merged

refactor(java): refactor java code for java binding#2145
Xuanwo merged 5 commits intoapache:mainfrom
ShadowySpirits:java_binding

Conversation

@ShadowySpirits
Copy link
Copy Markdown
Member

@ShadowySpirits ShadowySpirits commented Apr 27, 2023

fix #2144

@suyanhanx
Copy link
Copy Markdown
Member

suyanhanx commented Apr 27, 2023

We share behavioral tests between bindings. For new test, we may need to upgrade bindings together.

@ShadowySpirits
Copy link
Copy Markdown
Member Author

ShadowySpirits commented Apr 27, 2023

We share behavioral tests between bindings. For new test, we may need to upgrade bindings together.

I am willing to add a new test but do not familiar with python, node.js, etc (T⌓T). Could you please help me, or can I leave empty implementations for other languages to be added later?

Xuanwo
Xuanwo reviewed Apr 27, 2023
View reviewed changes
Comment thread bindings/java/src/main/java/org/apache/opendal/exception/OpenDALErrorCode.java
Comment thread bindings/java/src/test/java/org/apache/opendal/AsyncStepsTest.java Outdated
Comment thread bindings/java/src/test/resources/features/binding.feature Outdated
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Apr 27, 2023

I am willing to add a new test but do not familiar with python, node.js, etc (T⌓T). Could you please help me, or can I leave empty implementations for other languages to be added later?

We don't need to test the behavior, they are covered by our rust core.

@ShadowySpirits
Copy link
Copy Markdown
Member Author

ShadowySpirits commented Apr 29, 2023

I am willing to add a new test but do not familiar with python, node.js, etc (T⌓T). Could you please help me, or can I leave empty implementations for other languages to be added later?

We don't need to test the behavior, they are covered by our rust core.

According to the previous discussion, I keep the exception test in Java binding module.

Xuanwo
Xuanwo reviewed Apr 29, 2023
View reviewed changes
Comment thread bindings/java/src/test/resources/features/binding.feature Outdated
Comment thread bindings/java/src/test/java/org/apache/opendal/StepsTest.java Outdated
@ShadowySpirits ShadowySpirits requested a review from Xuanwo April 29, 2023 10:35
Xuanwo
Xuanwo approved these changes Apr 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit ec988b0 into apache:main Apr 29, 2023
@ShadowySpirits ShadowySpirits deleted the java_binding branch May 5, 2023 02:27
@Xuanwo Xuanwo mentioned this pull request May 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suyanhanx suyanhanx suyanhanx left review comments

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor java code for java binding

3 participants

@ShadowySpirits @suyanhanx @Xuanwo