Skip to content

feat(http_util): Implement multipart/mixed support#2161

Merged
Xuanwo merged 6 commits intomainfrom
multipart-mixed
Apr 28, 2023
Merged

feat(http_util): Implement multipart/mixed support#2161
Xuanwo merged 6 commits intomainfrom
multipart-mixed

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented Apr 28, 2023

This PR will add multipart/mixed support which makes it easier for developers to build requests with multipart/mixed content type.

Xuanwo added 5 commits April 28, 2023 18:13
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from suyanhanx April 28, 2023 13:15
@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Apr 28, 2023

cc @ClSlaid, please take a look.

@suyanhanx
Copy link
Copy Markdown
Member

suyanhanx commented Apr 28, 2023

😋It will be great if we could have a test for multi parts.(can be done in another PR.)
And we could also add a capability for this.

@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Apr 28, 2023

yumIt will be great if we could have a test for multi parts.(can be done in another PR.)

I don't understand. Both MixedPart and FormDataPart are already tested.

@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Apr 28, 2023

And we could also add a capability for this.

No. It's not a service capability.

@suyanhanx
Copy link
Copy Markdown
Member

And we could also add a capability for this.

No. It's not a service capability.

😨I mean the functions which use them(the two part).

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Apr 28, 2023

I mean the functions which use them(the two part).

Maybe you mean this? 36c7cc0

Copy link
Copy Markdown
Contributor

@ClSlaid ClSlaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good to see a fancy multipart implement!

Comment thread core/src/raw/http_util/multipart.rs
Comment thread core/src/raw/http_util/multipart.rs
@suyanhanx
Copy link
Copy Markdown
Member

I mean the functions which use them(the two part).

Maybe you mean this? 36c7cc0

Oh sorry. I saw the test. I wasn't at the computer just now.
Yep, that's the capability. But we can check it with others together later.

Copy link
Copy Markdown
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks!

@Xuanwo Xuanwo merged commit dd4a482 into main Apr 28, 2023
@Xuanwo Xuanwo deleted the multipart-mixed branch April 28, 2023 13:47
@Xuanwo Xuanwo mentioned this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants