feat(tests): Enable supabase integration tests#2190
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Sure, I will have a look at it. |
|
Seems supabase does not support special characters In Any ideas on this test? |
Supabase said:
Maybe we just need to make sure the path has been percent encoded? |
Following the first line is what we are using in our behavior tests. As I tested, the third line which removed '#', '%' and '^' works out fine. let path = format!("{} !@#$%^&()_+-=;',.txt", uuid::Uuid::new_v4());
// remove # % and ^
let path = format!("{} !@$&()_+-=;',.txt", uuid::Uuid::new_v4());In the Maybe we should remove these three characters, at least from the amazon's spec we should avoid these three. |
|
More like a bug: supabase/storage#133 As Supabase Storage is an open-source project, I would rather collaborate with the upstream team than find workarounds. |
|
Before this bug addressed, you can add code like the following for // Ignore test for supabase until https://github.com/apache/incubator-opendal/issues/2194 addressed.
if op.info().scheme() == Scheme::Supabase {
warn!("ignore test for supabase unitl https://github.com/apache/incubator-opendal/issues/2194 addressed")
return Ok(());
} |
|
Hi, @suyanhanx, I think we can merge this PR first and create a tracking issue for supabase's not passed test cases. |
It‘s ok to me. Just merge after the conflict is resolved. |
Tracked at #2199 |
This PR will enable supabase integration tests
failures: services_supabase::write_test_create_dir services_supabase::write_test_create_dir_existing services_supabase::write_test_delete services_supabase::write_test_delete_empty_dir services_supabase::write_test_delete_not_existing services_supabase::write_test_delete_stream services_supabase::write_test_delete_with_special_chars services_supabase::write_test_fuzz_offset_reader services_supabase::write_test_fuzz_part_reader services_supabase::write_test_fuzz_range_reader services_supabase::write_test_read_full services_supabase::write_test_read_large_range services_supabase::write_test_read_not_exist services_supabase::write_test_read_range services_supabase::write_test_read_with_dir_path services_supabase::write_test_read_with_special_chars services_supabase::write_test_reader_from services_supabase::write_test_reader_range services_supabase::write_test_reader_tail services_supabase::write_test_stat services_supabase::write_test_stat_dir services_supabase::write_test_stat_not_cleaned_path services_supabase::write_test_stat_not_exist services_supabase::write_test_stat_with_special_chars services_supabase::write_test_write services_supabase::write_test_write_with_special_chars test result: FAILED. 101 passed; 26 failed; 0 ignored; 0 measured; 1651 filtered out; finished in 17.56sHi, @Ji-Xinyou, many write related tests failed, would like to take a look?