Skip to content

feat(services/vercel): Add vercel remote cache support#2193

Merged
Xuanwo merged 4 commits intoapache:mainfrom
Retrospection:main
May 2, 2023
Merged

feat(services/vercel): Add vercel remote cache support#2193
Xuanwo merged 4 commits intoapache:mainfrom
Retrospection:main

Conversation

@Retrospection
Copy link
Copy Markdown
Contributor

close #2149

@Retrospection
Copy link
Copy Markdown
Contributor Author

Retrospection commented May 2, 2023

TODO:

  • fix ci
  • do some local test
  • Improve comments

@Retrospection Retrospection force-pushed the main branch 3 times, most recently from 8cf8260 to fc62b4e Compare May 2, 2023 12:16
@Retrospection Retrospection marked this pull request as ready for review May 2, 2023 12:22
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Here are some comments.

Comment thread core/src/services/mod.rs Outdated
Comment thread core/src/services/mod.rs Outdated
Comment thread core/src/services/vercel/backend.rs Outdated
Comment thread core/src/types/scheme.rs Outdated
@Retrospection Retrospection force-pushed the main branch 2 times, most recently from 4f2ae15 to 3b45299 Compare May 2, 2023 14:58
Comment thread core/src/services/vercel_artifacts/builder.rs Outdated
Signed-off-by: Retros <footsteprex@gmail.com>
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Retrospection
Copy link
Copy Markdown
Contributor Author

Great, thanks!

Thanks for your kind review~

Xuanwo added 3 commits May 3, 2023 01:00
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit 9154410 into apache:main May 2, 2023
@Xuanwo Xuanwo mentioned this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

services: Add support Vercel Remote Caching

2 participants