ci: Add tools to generate NOTICE and all deps licenses#2205
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
|
Hi, @tisonkun, would you like to help review this PR? |
PsiACE
left a comment
There was a problem hiding this comment.
LGTM, but not sure if all original text must be maintained in our repo
There was a problem hiding this comment.
I looked at some deps' licenses generated and found that they don't match reality. For example, napi, your tool generates an empty file, when in fact even if it does generate a mit license which is chosen by napi, it doesn't match the corresponding one because its contents have been changed by the author.
https://github.com/napi-rs/napi-rs/blob/main/LICENSE
First of all, it's a bug of Then, the And I think we don't need to include all licenses in our repo too, they are all declared in our NOTICE. I will wait for @tisonkun's comment. |
Signed-off-by: Xuanwo <github@xuanwo.io>
|
It seems better now. |
tisonkun
left a comment
There was a problem hiding this comment.
Looks good.
Maybe add a CI workflow to assert the NOTICE file is up-to-date.
No description provided.