feat(services/onedrive): Implement list, create_dir, stat and uploading large files#2231
Merged
Xuanwo merged 67 commits intoapache:mainfrom May 10, 2023
Merged
feat(services/onedrive): Implement list, create_dir, stat and uploading large files#2231Xuanwo merged 67 commits intoapache:mainfrom
list, create_dir, stat and uploading large files#2231Xuanwo merged 67 commits intoapache:mainfrom
Conversation
This reverts commit 0d8e16c.
# Conflicts: # core/src/services/onedrive/backend.rs
Xuanwo
reviewed
May 10, 2023
Contributor
Author
|
Could we not support new capability 
|
Member
If |
Contributor
Author
Oh, just got it! Thanks! I updated that flag and all test passed: |
Contributor
Author
|
Sorry, previously I only ran this test with 10 dirs pub async fn test_list_rich_dir(op: Operator) -> Result<()> {
op.create_dir("test_list_rich_dir/").await?;
let mut expected: Vec<String> = (0..=1000)
.map(|num| format!("test_list_rich_dir/file-{num}"))
.collect();Let me run full tests again coz I found an error (fixed by c73f99e) Update: Full behavior test passed: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the implementation of these four operations:
listcreate_dirstatuploadfor files that are larger than 4MB (using upload session / chunked uploading)Please note that we haven't set up behavior test of OneDrive yet.
I ran all behavior tests locally and it passed:
Click to expand test log
Related issue: #1099