Skip to content

fix(services/s3): Return error if region not set for AWS S3#2234

Merged
Xuanwo merged 1 commit intomainfrom
s3-region
May 8, 2023
Merged

fix(services/s3): Return error if region not set for AWS S3#2234
Xuanwo merged 1 commit intomainfrom
s3-region

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented May 8, 2023

Fix #2201

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested review from ClSlaid, PsiACE and sundy-li as code owners May 8, 2023 08:19
@Xuanwo Xuanwo merged commit c1d0c6c into main May 8, 2023
@Xuanwo Xuanwo deleted the s3-region branch May 8, 2023 08:53
suyanhanx pushed a commit to suyanhanx/opendal that referenced this pull request May 8, 2023
@Xuanwo Xuanwo mentioned this pull request May 9, 2023
@saiintbrisson
Copy link
Copy Markdown
Contributor

saiintbrisson commented May 9, 2023

Hi! This change missed the doc here: https://github.com/apache/incubator-opendal/blob/21ebe0fc4f23f0a4a2eb01418e4e728599c090ae/core/src/services/s3/backend.rs#L373

I'll come up with a PR to fix it

@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented May 9, 2023

Hi! This change missed the doc here:

Oh, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

s3: Raise an error if region is not detected

3 participants