Skip to content

feat(services/gcs): Add abort support for writer#2242

Merged
Xuanwo merged 4 commits intomainfrom
gcs-writer-abort
May 8, 2023
Merged

feat(services/gcs): Add abort support for writer#2242
Xuanwo merged 4 commits intomainfrom
gcs-writer-abort

Conversation

@suyanhanx
Copy link
Copy Markdown
Member

close #2240

Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Comment thread core/src/services/gcs/writer.rs Outdated
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented May 8, 2023

We need to merge #2241 first.

Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx marked this pull request as ready for review May 8, 2023 16:43
Comment thread core/src/services/gcs/writer.rs Outdated
suyanhanx added 2 commits May 9, 2023 00:50
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xuanwo Xuanwo merged commit 60bcbf7 into main May 8, 2023
@Xuanwo Xuanwo deleted the gcs-writer-abort branch May 8, 2023 17:03
@Xuanwo Xuanwo mentioned this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

services/gcs: Implement Writer Abort

2 participants