feat(core): add presign support for obs#2253
Merged
suyanhanx merged 2 commits intoapache:mainfrom May 16, 2023
Merged
Conversation
cuichenli
requested review from
ClSlaid,
PsiACE,
Xuanwo and
sundy-li
as code owners
Contributor
Author
|
some side notes: noticed there are a lot of code duplicates, for instance: also for the |
Xuanwo
reviewed
May 11, 2023
Member
We can call
Make it a trait is not helpful because one service one has one valid |
suyanhanx
reviewed
May 11, 2023
Contributor
Author
|
thanks, updated based on the comments above. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #2070
noticed that oss already have the presign support, so this pr only touches obs.