Skip to content

feat(bindings/C): support BDD tests using GTest#2254

Merged
Xuanwo merged 15 commits intoapache:mainfrom
xyjixyjixyji:gtest-c
May 11, 2023
Merged

feat(bindings/C): support BDD tests using GTest#2254
Xuanwo merged 15 commits intoapache:mainfrom
xyjixyjixyji:gtest-c

Conversation

@xyjixyjixyji
Copy link
Copy Markdown
Contributor

This PR does

  • add gtest dependency
  • implement BDD Tests with gtest
  • remove basicio.c

Signed-off-by: Ji-Xinyou <jerryji0414@outlook.com>
Signed-off-by: Ji-Xinyou <jerryji0414@outlook.com>
Signed-off-by: Ji-Xinyou <jerryji0414@outlook.com>
Signed-off-by: Ji-Xinyou <jerryji0414@outlook.com>
@xyjixyjixyji
Copy link
Copy Markdown
Contributor Author

Related #2185

@xyjixyjixyji
Copy link
Copy Markdown
Contributor Author

xyjixyjixyji commented May 11, 2023

The typo check failed on GTest headers.

Followup:
I remove the GTest headers for this PR, which requires developers to have gtest headers on their own machines. Since we have to link with libgtest anyway, I think it would be fine.

I will explain this in detail on the contributing doc PR.

Signed-off-by: Ji-Xinyou <jerryji0414@outlook.com>
Signed-off-by: Ji-Xinyou <jerryji0414@outlook.com>
Signed-off-by: Ji-Xinyou <jerryji0414@outlook.com>
@xyjixyjixyji

This comment was marked as resolved.

Signed-off-by: Ji-Xinyou <jerryji0414@outlook.com>
Comment thread bindings/c/tests/bdd.cpp Outdated
Signed-off-by: Ji-Xinyou <jerryji0414@outlook.com>
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented May 11, 2023

We need a workflow to make sure it works.

Signed-off-by: Ji-Xinyou <jerryji0414@outlook.com>
@xyjixyjixyji

This comment was marked as resolved.

Signed-off-by: Ji-Xinyou <jerryji0414@outlook.com>
Signed-off-by: Ji-Xinyou <jerryji0414@outlook.com>
@xyjixyjixyji

This comment was marked as resolved.

Signed-off-by: Ji-Xinyou <jerryji0414@outlook.com>
@xyjixyjixyji
Copy link
Copy Markdown
Contributor Author

Works perfectly now

Comment thread .github/workflows/bindings_c.yml Outdated
Comment thread .github/workflows/bindings_c.yml
Comment thread .github/workflows/bindings_c.yml Outdated
Signed-off-by: Ji-Xinyou <jerryji0414@outlook.com>
Signed-off-by: Ji-Xinyou <jerryji0414@outlook.com>
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xuanwo Xuanwo merged commit 5d89060 into apache:main May 11, 2023
@Xuanwo Xuanwo mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants