Skip to content

feat(bindings/python): Enable abi3 to avoid building on different python version#2255

Merged
Xuanwo merged 1 commit intoapache:mainfrom
frostming:frostming/issue2252
May 11, 2023
Merged

feat(bindings/python): Enable abi3 to avoid building on different python version#2255
Xuanwo merged 1 commit intoapache:mainfrom
frostming:frostming/issue2252

Conversation

@frostming
Copy link
Copy Markdown
Contributor

@frostming frostming commented May 11, 2023

Fixes #2252

Signed-off-by: Frost Ming me@frostming.com

chrono::Duration <-> pyo3::types::PyDelta is not availiable under Py_Limited_API, so I switch it to float(in seconds) instead.

…ython version

Fixes apache#2252

Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming force-pushed the frostming/issue2252 branch from b95d304 to 7e7296d Compare May 11, 2023 11:22
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit 8ef38ac into apache:main May 11, 2023
@frostming frostming deleted the frostming/issue2252 branch May 11, 2023 11:31
@Xuanwo Xuanwo mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bindings/python: Enable abi3 to avoid building on different python version

2 participants