Skip to content

feat(services/webdav): support redirection when get 302/307 response during read operation#2256

Merged
Xuanwo merged 44 commits intoapache:mainfrom
Gnosnay:feature/support-redirect-for-webdav
May 30, 2023
Merged

feat(services/webdav): support redirection when get 302/307 response during read operation#2256
Xuanwo merged 44 commits intoapache:mainfrom
Gnosnay:feature/support-redirect-for-webdav

Conversation

@Gnosnay
Copy link
Copy Markdown
Contributor

@Gnosnay Gnosnay commented May 11, 2023 •
edited
Loading

related issue: #2146

Xuanwo
Xuanwo reviewed May 11, 2023
View reviewed changes
Comment thread core/src/services/webdav/backend.rs Outdated
Gnosnay
Gnosnay commented May 15, 2023
View reviewed changes
Comment thread core/src/services/webdav/fixtures/nginx.conf Outdated
Xuanwo
Xuanwo reviewed May 16, 2023
View reviewed changes
Comment thread .github/workflows/service_test_webdav.yml Outdated
Comment thread core/src/services/webdav/backend.rs Outdated
Comment thread core/src/services/webdav/backend.rs Outdated
@dtretyakov
Copy link
Copy Markdown

dtretyakov commented May 26, 2023

@Yansongsongsong are you still working on addressing review comments or you have no time?

@Gnosnay
Copy link
Copy Markdown
Contributor Author

Gnosnay commented May 27, 2023

@Yansongsongsong are you still working on addressing review comments or you have no time?

@dtretyakov hi i am still working on that. i may push my change tmr. sorry for late

@Gnosnay
Copy link
Copy Markdown
Contributor Author

Gnosnay commented May 28, 2023

hi @Xuanwo , sorry for late. have refactored according to the review. please have one look at this. thank you

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented May 30, 2023

hi @Xuanwo , sorry for late. have refactored according to the review. please have one look at this. thank you

Sorry for miss this comment, I will take a look today.

@Xuanwo Xuanwo added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label May 30, 2023
Xuanwo
Xuanwo approved these changes May 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented May 30, 2023

Please resolve the conflict so that we can merge this PR in!

@Gnosnay
Copy link
Copy Markdown
Contributor Author

Gnosnay commented May 30, 2023

Please resolve the conflict so that we can merge this PR in!

@Xuanwo conflicts resolved. thank you for mentoring.

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented May 30, 2023

Hi, @Yansongsongsong please update branch and try again. Sorry for our fault.

@Xuanwo Xuanwo merged commit fc7207e into apache:main May 30, 2023
@Xuanwo Xuanwo mentioned this pull request May 30, 2023
Closed
@suyanhanx
Copy link
Copy Markdown
Member

suyanhanx commented May 30, 2023

I've updated it for you. Thanks for your hard work!

@Xuanwo Xuanwo mentioned this pull request Jun 2, 2023
Merged
@suyanhanx suyanhanx mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees

No one assigned

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Gnosnay @dtretyakov @Xuanwo @suyanhanx