docs: Unify capabilities list for kv services#2257
docs: Unify capabilities list for kv services#2257Xuanwo merged 3 commits intoapache:mainfrom lqhuang:add-scan-to-capability
Conversation
Yes, they are by design. We removed scan in previous refactor.
Not. They can't be migrated to typed_kv since they can't store a typed_kv::Value with zero cost.
No, we don't do refactor like this kind. Current code structure is clean and easy to understand. |
|
@Xuanwo Thanks for reply! I reverted change of
Any material or discussion about the design? |
|
Thank you for fixing this! Wish it is help to you. |
In the very first, I want to migrate
sled/rocksdbservices totyped_kv. But I foundtyped_kvhas its own data schema (metadata+value), it seems would break loading and writing of existed data? Discussion is required here.Then I found the type
crate::Capabilitydoesn't havescanflag, is this intentional result or deliberate design?Then for this PR,
scanflag to generalCapabilityNotes:
cargo testpassed locally.scanflag for those services capable withscanhaven't set totrueyet.Further discussions:
typed_kvmigration forsled/rocksdb/memorycache/redisBlockCapability; 2.ObjectCapability, 3.KvCapabilityThis's my first PR for OpenDAL 😀 Please check more in details.
Thanks for your efforts!
Sincerely,
Lanqing