Skip to content

feat(services/dropbox): Support create/read/delete for Dropbox#2264

Merged
Xuanwo merged 1 commit intoapache:mainfrom
Zheaoli:manjusaka/support-dropbox
Jun 20, 2023
Merged

feat(services/dropbox): Support create/read/delete for Dropbox#2264
Xuanwo merged 1 commit intoapache:mainfrom
Zheaoli:manjusaka/support-dropbox

Conversation

@Zheaoli
Copy link
Copy Markdown
Member

@Zheaoli Zheaoli commented May 15, 2023

close #1098

@Zheaoli Zheaoli marked this pull request as draft May 15, 2023 17:55
@Zheaoli Zheaoli force-pushed the manjusaka/support-dropbox branch from 13e933e to 428fabe Compare May 15, 2023 17:56
@suyanhanx

This comment was marked as outdated.

Comment thread core/src/services/mod.rs
Comment thread core/src/services/dropbox/backend.rs Outdated
Comment thread core/src/services/dropbox/builder.rs Outdated
Comment thread core/src/services/dropbox/core.rs Outdated
Comment thread core/src/services/dropbox/core.rs Outdated
Comment thread core/src/services/dropbox/core.rs Outdated
@Zheaoli Zheaoli force-pushed the manjusaka/support-dropbox branch from 3487389 to 837bf9a Compare June 17, 2023 14:44
@Zheaoli Zheaoli changed the title [WIP]feat(services/dropbox): Support create/read/rename/copy/delete for Dropbox [WIP]feat(services/dropbox): Support create/read/delete for Dropbox Jun 17, 2023
@Zheaoli Zheaoli requested a review from Xuanwo June 17, 2023 14:47
@suyanhanx
Copy link
Copy Markdown
Member

We updated the raw API a while ago and added sink support for the writer. Please update, thanks.

@Zheaoli Zheaoli marked this pull request as ready for review June 17, 2023 17:46
@Zheaoli Zheaoli changed the title [WIP]feat(services/dropbox): Support create/read/delete for Dropbox feat(services/dropbox): Support create/read/delete for Dropbox Jun 17, 2023
Comment thread core/src/services/dropbox/error.rs
Comment thread core/src/services/dropbox/core.rs Outdated
Comment thread core/src/services/dropbox/core.rs Outdated
Comment thread core/src/services/dropbox/core.rs Outdated
Comment thread core/src/services/dropbox/core.rs Outdated
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jun 18, 2023
@Zheaoli Zheaoli force-pushed the manjusaka/support-dropbox branch 2 times, most recently from dec8a69 to 6c4b8bf Compare June 18, 2023 17:26
Comment thread core/src/services/dropbox/builder.rs Outdated
@Zheaoli Zheaoli force-pushed the manjusaka/support-dropbox branch 2 times, most recently from 77132fa to c08d98d Compare June 19, 2023 15:44
@Zheaoli Zheaoli requested a review from Xuanwo June 19, 2023 15:56
@Zheaoli Zheaoli force-pushed the manjusaka/support-dropbox branch from c08d98d to 3bdc51a Compare June 19, 2023 15:57
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. Thanks for you work! The thing left here maybe make clippy happy.

@Zheaoli Zheaoli requested review from Xuanwo and suyanhanx June 20, 2023 09:50
@Zheaoli Zheaoli force-pushed the manjusaka/support-dropbox branch 4 times, most recently from 0882719 to 075041b Compare June 20, 2023 11:57
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli Zheaoli force-pushed the manjusaka/support-dropbox branch from 075041b to 7952b47 Compare June 20, 2023 11:59
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit f7e175d into apache:main Jun 20, 2023
@Zheaoli Zheaoli deleted the manjusaka/support-dropbox branch June 20, 2023 14:52
@PsiACE PsiACE mentioned this pull request Jun 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Dropbox Support

3 participants