feat(services/dropbox): Support create/read/delete for Dropbox#2264
Merged
Xuanwo merged 1 commit intoapache:mainfrom Jun 20, 2023
Merged
feat(services/dropbox): Support create/read/delete for Dropbox#2264Xuanwo merged 1 commit intoapache:mainfrom
Xuanwo merged 1 commit intoapache:mainfrom
Conversation
13e933e to
428fabe
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Xuanwo
reviewed
May 16, 2023
3487389 to
837bf9a
Compare
Member
|
We updated the raw API a while ago and added sink support for the writer. Please update, thanks. |
Xuanwo
reviewed
Jun 18, 2023
dec8a69 to
6c4b8bf
Compare
suyanhanx
reviewed
Jun 18, 2023
77132fa to
c08d98d
Compare
c08d98d to
3bdc51a
Compare
Xuanwo
reviewed
Jun 20, 2023
Member
Xuanwo
left a comment
There was a problem hiding this comment.
Mostly LGTM. Thanks for you work! The thing left here maybe make clippy happy.
0882719 to
075041b
Compare
Signed-off-by: Manjusaka <me@manjusaka.me>
075041b to
7952b47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1098