feat(services/sftp): support copy and read_seek#2267
Merged
Xuanwo merged 4 commits intoapache:mainfrom May 17, 2023
silver-ymz:feat/sftp-copy-seek
Merged
feat(services/sftp): support copy and read_seek#2267Xuanwo merged 4 commits intoapache:mainfrom silver-ymz:feat/sftp-copy-seek
Xuanwo merged 4 commits intoapache:mainfrom
silver-ymz:feat/sftp-copy-seek
Conversation
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Member
|
Return an error when call |
Xuanwo
reviewed
May 17, 2023
Member
We will handle this in general in the future, for example, check capability before calling. |
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Member
Author
Current implementation is to return an error of |
Member
Author
|
And may I ask is there anything else need to do about sftp? I think all available features have done. |
Member
I guess we don't need to do more until we have user's feature request. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update:
SftpBuilderto make user provide info about remote server extensionopenssh-sftp-clientversion to 0.13.5 to fix the bug ofAsyncSeekread_can_seekinCapability