Skip to content

feat(services/oss): add append support#2279

Merged
Xuanwo merged 6 commits intomainfrom
append-oss
May 23, 2023
Merged

feat(services/oss): add append support#2279
Xuanwo merged 6 commits intomainfrom
append-oss

Conversation

@suyanhanx
Copy link
Copy Markdown
Member

@suyanhanx suyanhanx commented May 22, 2023

Add append support for OSS.

Comment thread core/src/services/oss/core.rs Outdated
Comment thread core/src/services/oss/core.rs Outdated
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
suyanhanx added 2 commits May 22, 2023 23:10
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@Xuanwo

This comment was marked as off-topic.

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented May 22, 2023

Seems our layered accessor is not implemented correctly.

Signed-off-by: suyanhanx <suyanhanx@gmail.com>
suyanhanx added 2 commits May 23, 2023 10:28
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx marked this pull request as ready for review May 23, 2023 02:56
@suyanhanx
Copy link
Copy Markdown
Member Author

Seems our layered accessor is not implemented correctly.

Just I missed adding the append method. 🤣

Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 01e70a6 into main May 23, 2023
@Xuanwo Xuanwo deleted the append-oss branch May 23, 2023 03:19
@Xuanwo Xuanwo mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants