Skip to content

feat(core): public API of append#2284

Merged
Xuanwo merged 2 commits intomainfrom
append-public
May 22, 2023
Merged

feat(core): public API of append#2284
Xuanwo merged 2 commits intomainfrom
append-public

Conversation

@suyanhanx
Copy link
Copy Markdown
Member

@suyanhanx suyanhanx commented May 22, 2023

This PR adds public API of append.

With four methods for the operator:

  • append
  • appender
  • append_with
  • appender_with

And async_write.

Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Comment thread core/src/types/operator/operator.rs Outdated
Comment thread core/src/types/operator/operator.rs Outdated
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Please mark your PR as ready for review when you are ready for review instead a draft.

@Xuanwo Xuanwo marked this pull request as ready for review May 22, 2023 12:37
@Xuanwo Xuanwo merged commit 8532b4c into main May 22, 2023
@Xuanwo Xuanwo deleted the append-public branch May 22, 2023 12:37
@Xuanwo Xuanwo mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants