Skip to content

refactor(bindings/java): split different classes#2288

Merged
tisonkun merged 9 commits intoapache:mainfrom
tisonkun:async-op
May 23, 2023
Merged

refactor(bindings/java): split different classes#2288
tisonkun merged 9 commits intoapache:mainfrom
tisonkun:async-op

Conversation

@tisonkun
Copy link
Copy Markdown
Member

@tisonkun tisonkun commented May 22, 2023

Please review in commits. The title of commit should express what I do.

Comment thread bindings/java/src/convert.rs Outdated
Comment thread bindings/java/src/convert.rs Outdated
Comment thread bindings/java/src/convert.rs Outdated
Comment thread bindings/java/src/test/java/org/apache/opendal/ExceptionTest.java Outdated
Comment thread bindings/java/src/lib.rs Outdated
tisonkun added 7 commits May 23, 2023 10:34
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Copy Markdown
Member Author

@Xuanwo updated.

@tisonkun tisonkun requested a review from Xuanwo May 23, 2023 02:37
tisonkun added 2 commits May 23, 2023 10:40
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented May 23, 2023

Check failed for

[main] INFO io.korandoru.hawkeye.command.HawkEyeCommandCheck - Found missing header files: [/github/workspace/bindings/java/src/error.rs]

@tisonkun
Copy link
Copy Markdown
Member Author

@Xuanwo Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants