Skip to content

fix(services/supabase): correctly set retryable #2295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xuanwo merged 1 commit into from
May 23, 2023
Merged

fix(services/supabase): correctly set retryable #2295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions core/src/services/supabase/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,18 @@ pub async fn parse_error(resp: Response<IncomingAsyncBody>) -> Result<Error> {
// Return the error kind and whether it is retryable
fn parse_supabase_error(err: &SupabaseError) -> (ErrorKind, bool) {
let code = err.status_code.parse::<u16>().unwrap();
if code == StatusCode::CONFLICT.as_u16() && err.error == "Duplicate" {
(ErrorKind::AlreadyExists, false)
} else if code == StatusCode::NOT_FOUND.as_u16() {
(ErrorKind::NotFound, false)
} else if code == StatusCode::FORBIDDEN.as_u16() {
(ErrorKind::PermissionDenied, false)
} else if code == StatusCode::PRECONDITION_FAILED.as_u16() {
(ErrorKind::ConditionNotMatch, false)
} else {
(ErrorKind::Unexpected, false)
let status_code = StatusCode::from_u16(code).unwrap();
match status_code {
StatusCode::CONFLICT => (ErrorKind::AlreadyExists, false),
StatusCode::NOT_FOUND => (ErrorKind::NotFound, false),
StatusCode::FORBIDDEN => (ErrorKind::PermissionDenied, false),
StatusCode::PRECONDITION_FAILED | StatusCode::NOT_MODIFIED => {
(ErrorKind::ConditionNotMatch, false)
}
StatusCode::INTERNAL_SERVER_ERROR
| StatusCode::BAD_GATEWAY
| StatusCode::SERVICE_UNAVAILABLE
| StatusCode::GATEWAY_TIMEOUT => (ErrorKind::Unexpected, true),
_ => (ErrorKind::Unexpected, false),
}
}