feat(services/sftp): add append support for sftp#2297
Merged
Xuanwo merged 2 commits intoapache:mainfrom May 23, 2023
silver-ymz:feat/sftp-append
Merged
feat(services/sftp): add append support for sftp#2297Xuanwo merged 2 commits intoapache:mainfrom silver-ymz:feat/sftp-append
Xuanwo merged 2 commits intoapache:mainfrom
silver-ymz:feat/sftp-append
Conversation
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
silver-ymz
requested review from
ClSlaid,
PsiACE,
Xuanwo and
sundy-li
as code owners
Member
Yes, it's a bug. cc @suyanhanx, we should close the appender by hand. |
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Member
fixed in #2298 🥲 This is due to incorrect detection. |
suyanhanx
reviewed
May 23, 2023
11 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated:
In the tests, we will receive warning
opendal::layers::complete: appender has not been closed, must be a bug. It also exists in github action test forfsimplementation. Should we concern about it?