Skip to content

refactor(core): Implement RFC-2299 for stat_with#2303

Merged
Xuanwo merged 3 commits intomainfrom
rfc-2299
May 24, 2023
Merged

refactor(core): Implement RFC-2299 for stat_with#2303
Xuanwo merged 3 commits intomainfrom
rfc-2299

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented May 24, 2023

part of #2300

from

if let Err(e) = op.stat_with("test", OpStat::new().with_if_match("<etag>")).await {
    if e.kind() == ErrorKind::NotFound {
        println!("file not exist")
    }
}

to

if let Err(e) = op.stat_with("test").if_match("<etag>").await {
    if e.kind() == ErrorKind::NotFound {
        println!("file not exist")
    }
}

Signed-off-by: Xuanwo <github@xuanwo.io>
Comment thread core/src/types/operator/operator_futures.rs Outdated
Xuanwo added 2 commits May 24, 2023 17:13
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented May 24, 2023

cc @suyanhanx to take another look.

Comment thread core/src/types/operator/operator_futures.rs
Comment thread core/src/types/operator/operator_futures.rs
Copy link
Copy Markdown
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@Xuanwo Xuanwo merged commit 5dc2736 into main May 24, 2023
@Xuanwo Xuanwo deleted the rfc-2299 branch May 24, 2023 10:02
@Xuanwo Xuanwo mentioned this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants