Skip to content

ci(binding/nodejs): Use docker to build nodejs binding#2328

Merged
Xuanwo merged 4 commits intomainfrom
fix-node
May 26, 2023
Merged

ci(binding/nodejs): Use docker to build nodejs binding#2328
Xuanwo merged 4 commits intomainfrom
fix-node

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented May 26, 2023

This PR will use ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-debian to build nodejs binding.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from suyanhanx May 26, 2023 07:24
@suyanhanx
Copy link
Copy Markdown
Member

May we build one time to verify?

@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented May 26, 2023

May we build one time to verify?

I have tested locally, maybe you want to test it in your own fork?

@suyanhanx
Copy link
Copy Markdown
Member

May we build one time to verify?

I have tested locally, maybe you want to test it in your own fork?

I'll try.

Comment thread .github/workflows/bindings_nodejs.yml Outdated
suyanhanx and others added 3 commits May 26, 2023 16:21
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: Xuanwo <github@xuanwo.io>
This reverts commit 098dca0.
Copy link
Copy Markdown
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit defaa6f into main May 26, 2023
@Xuanwo Xuanwo deleted the fix-node branch May 26, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants