feat(core): server side encryption support for azblob#2347
Merged
Xuanwo merged 8 commits intoapache:mainfrom May 30, 2023
Merged
feat(core): server side encryption support for azblob#2347Xuanwo merged 8 commits intoapache:mainfrom
Xuanwo merged 8 commits intoapache:mainfrom
Conversation
Member
|
I prefer to have separately options which is easier to be fetched from env or hashmap. And we can provide a |
Xuanwo
reviewed
May 28, 2023
fe6241f to
2e4b8ce
Compare
Xuanwo
reviewed
May 29, 2023
d8719dc to
8d4e4dd
Compare
This was referenced May 30, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes Made
Add SSE headers into these requests
Additional Notes
Helper Function Design
Hi @Xuanwo, what do you think about these two functions? Should we provide them separately or together? (Also, since azblob only support for AES256 as encryption algorithm, do we still need to provide setting options for user?)
Test Case Design
I haven't implemented testing for this change, any suggestion? (I assume it can leverage Azurite in GitHub Actions)