feat(bindings/java): save one jni call in the hot path#2353
Merged
Xuanwo merged 1 commit intoapache:mainfrom May 28, 2023
Merged
feat(bindings/java): save one jni call in the hot path#2353Xuanwo merged 1 commit intoapache:mainfrom
Xuanwo merged 1 commit intoapache:mainfrom
Conversation
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
requested review from
ClSlaid,
PsiACE,
Xuanwo and
sundy-li
as code owners
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may not be necessary within single language scope since we can trust the compiler or JIT to inline code as much as possible.
But it's valuable when calls cross language boundaries since no optimization can happen here. Also, obtaining a future and getting it to complete is the hot path for all async ops. Thus I believe it is worth trading off some code style (static method over singleton and then call member method) for efficiency.