Skip to content

refactor(bindings/zig): enable tests and more#2375

Merged
Xuanwo merged 12 commits intoapache:mainfrom
tisonkun:zig
May 31, 2023
Merged

refactor(bindings/zig): enable tests and more#2375
Xuanwo merged 12 commits intoapache:mainfrom
tisonkun:zig

Conversation

@tisonkun
Copy link
Copy Markdown
Member

@tisonkun tisonkun commented May 31, 2023

Wait a bit for INFRA approve actions - #2374 actually won't run tests so it contains a wart 33650ae.

tisonkun added 7 commits May 31, 2023 12:24
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun marked this pull request as draft May 31, 2023 05:37
@github-actions github-actions Bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label May 31, 2023
@tisonkun
Copy link
Copy Markdown
Member Author

cc @kassane

Comment thread bindings/zig/src/opendal.zig
Comment thread bindings/zig/src/opendal.zig
tisonkun added 2 commits May 31, 2023 13:49
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun marked this pull request as ready for review May 31, 2023 08:37
@tisonkun
Copy link
Copy Markdown
Member Author

Ready for review now

Comment thread .github/workflows/bindings_zig.yml Outdated
tisonkun added 2 commits May 31, 2023 16:39
Signed-off-by: tison <wander4096@gmail.com>
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xuanwo Xuanwo merged commit fd5a287 into apache:main May 31, 2023
@tisonkun tisonkun deleted the zig branch May 31, 2023 09:11
@Xuanwo Xuanwo mentioned this pull request Jun 2, 2023
@suyanhanx suyanhanx mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants