Skip to content

docs: service doc for s3#2376

Merged
Xuanwo merged 4 commits intoapache:mainfrom
suyanhanx:sfs
May 31, 2023
Merged

docs: service doc for s3#2376
Xuanwo merged 4 commits intoapache:mainfrom
suyanhanx:sfs

Conversation

@suyanhanx
Copy link
Copy Markdown
Member

This PR adds docs for s3.

For better display on the site and anchor availability, I adjusted the title levels of the updated documents.

@github-actions github-actions Bot added the releases-note/docs The PR modifies docs related content or has a title that begins with "docs" label May 31, 2023
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx marked this pull request as draft May 31, 2023 06:12
suyanhanx added 2 commits May 31, 2023 14:13
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx marked this pull request as ready for review May 31, 2023 06:52
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM, thanks for the doc!

Comment thread core/src/services/s3/compatible_services.md
Comment thread website/docs/services/s3.mdx
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit 174533f into apache:main May 31, 2023
@suyanhanx suyanhanx deleted the sfs branch May 31, 2023 07:38
@suyanhanx suyanhanx mentioned this pull request May 31, 2023
29 tasks
@Xuanwo Xuanwo mentioned this pull request Jun 2, 2023
@suyanhanx suyanhanx mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/docs The PR modifies docs related content or has a title that begins with "docs"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants