Skip to content

feat: Implement Timeout Layer#2395

Merged
Xuanwo merged 6 commits intomainfrom
timeout-layer'
Jun 1, 2023
Merged

feat: Implement Timeout Layer#2395
Xuanwo merged 6 commits intomainfrom
timeout-layer'

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented Jun 1, 2023

This PR will add timeout layer for OpenDAL so users can avoid waiting for hang operations.

Signed-off-by: Xuanwo <github@xuanwo.io>
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jun 1, 2023
Xuanwo added 2 commits June 1, 2023 17:47
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link
Copy Markdown
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread core/src/layers/timeout.rs Outdated
Comment thread core/src/layers/timeout.rs Outdated
Comment thread core/src/layers/timeout.rs Outdated
Xuanwo and others added 3 commits June 1, 2023 18:23
Co-authored-by: Suyan <suyanhanx@gmail.com>
Co-authored-by: Suyan <suyanhanx@gmail.com>
Co-authored-by: Suyan <suyanhanx@gmail.com>
@Xuanwo Xuanwo merged commit d291356 into main Jun 1, 2023
@Xuanwo Xuanwo deleted the timeout-layer' branch June 1, 2023 10:25
@suyanhanx
Copy link
Copy Markdown
Member

suyanhanx commented Jun 1, 2023

You may need to specify in the documentation that the order in which the layer is configured affects the timing and that it, the timeout layer, should be configured first.
We can indicate in the documentation how to configure the layers appropriately.

@Xuanwo Xuanwo mentioned this pull request Jun 2, 2023
@suyanhanx suyanhanx mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants