Skip to content

ci: Enable nextest for all behavior tests#2400

Merged
Xuanwo merged 14 commits intomainfrom
refactor-nextest
Jun 2, 2023
Merged

ci: Enable nextest for all behavior tests#2400
Xuanwo merged 14 commits intomainfrom
refactor-nextest

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented Jun 2, 2023

No description provided.

Signed-off-by: Xuanwo <github@xuanwo.io>
@github-actions github-actions Bot added the releases-note/ci The PR modifies CI-related content or has a title that begins with "ci" label Jun 2, 2023
Xuanwo added 5 commits June 2, 2023 14:06
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Comment thread .github/workflows/service_test_hdfs.yml Outdated
Xuanwo added 6 commits June 2, 2023 15:18
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from xyjixyjixyji June 2, 2023 08:17
Comment thread .github/workflows/service_test_fs.yml
Comment thread .github/workflows/service_test_gcs.yml Outdated
@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Jun 2, 2023

Let's make this PR the first one for @Ji-Xinyou to review as a committer!

Signed-off-by: Xuanwo <github@xuanwo.io>
Comment thread .github/workflows/service_test_gcs.yml
@suyanhanx
Copy link
Copy Markdown
Member

image

May we reduce the sample counts of this test? Requesting COS seems to be too slow.

@xyjixyjixyji
Copy link
Copy Markdown
Contributor

xyjixyjixyji commented Jun 2, 2023

image

May we reduce the sample counts of this test? Requesting COS seems to be too slow.

I checked that each request takes about 250ms to return. Is this magnitude of latency unacceptable?

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Jun 2, 2023

May we reduce the sample counts of this test? Requesting COS seems to be too slow.

Yes, fixed.

@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Jun 2, 2023

cos drop from 10m to 5m by replace with a bucket in us region.

@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Jun 2, 2023

cc @suyanhanx & @Ji-Xinyou to take another look.

Copy link
Copy Markdown
Contributor

@xyjixyjixyji xyjixyjixyji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xuanwo Xuanwo merged commit 509b02c into main Jun 2, 2023
@Xuanwo Xuanwo deleted the refactor-nextest branch June 2, 2023 09:34
@Xuanwo Xuanwo mentioned this pull request Jun 2, 2023
@suyanhanx suyanhanx mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/ci The PR modifies CI-related content or has a title that begins with "ci"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants