feat(bindings/c): add opendal_operator_blocking_delete method#2416
Merged
xyjixyjixyji merged 1 commit intoapache:mainfrom Jun 5, 2023
Merged
feat(bindings/c): add opendal_operator_blocking_delete method#2416xyjixyjixyji merged 1 commit intoapache:mainfrom
xyjixyjixyji merged 1 commit intoapache:mainfrom
Conversation
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
jiaoew1991
requested review from
ClSlaid,
PsiACE,
Xuanwo and
sundy-li
as code owners
github-actions
Bot
added
the
releases-note/feat
jiaoew1991
force-pushed
the
c-blocking-delete
branch
from
c240128 to
99389fe
Compare
xyjixyjixyji
reviewed
Jun 5, 2023
Contributor
xyjixyjixyji
left a comment
xyjixyjixyji
left a comment
There was a problem hiding this comment.
Thanks for the work, the function implementation is basically correct. But there exists a few points that need some polishments 😃
jiaoew1991
force-pushed
the
c-blocking-delete
branch
2 times, most recently
from
c4cdefa to
03e018d
Compare
xyjixyjixyji
approved these changes
Jun 5, 2023
Contributor
xyjixyjixyji
left a comment
xyjixyjixyji
left a comment
There was a problem hiding this comment.
Thanks for the work! Lets wait the CI to pass.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.