Skip to content

feat(blocking operator): add remove_all api#2449

Merged
Xuanwo merged 8 commits intoapache:mainfrom
infdahai:remove_all_block
Jun 21, 2023
Merged

feat(blocking operator): add remove_all api#2449
Xuanwo merged 8 commits intoapache:mainfrom
infdahai:remove_all_block

Conversation

@infdahai
Copy link
Copy Markdown
Contributor

@infdahai infdahai commented Jun 11, 2023

close #2439

Signed-off-by: clundro <infdahai@outlook.com>
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jun 11, 2023
Signed-off-by: clundro <infdahai@outlook.com>
Comment thread core/src/types/operator/blocking_operator.rs Outdated
infdahai added 2 commits June 12, 2023 00:45
Signed-off-by: clundro <infdahai@outlook.com>
Signed-off-by: clundro <infdahai@outlook.com>
@infdahai
Copy link
Copy Markdown
Contributor Author

do we range the vector to call remove_via for implementing remove?

Comment thread core/src/types/operator/blocking_operator.rs Outdated
Comment thread core/src/types/operator/blocking_operator.rs Outdated
Comment thread core/src/types/operator/blocking_operator.rs Outdated
@infdahai
Copy link
Copy Markdown
Contributor Author

Dose my code cause the CI fails?

@infdahai infdahai requested review from Xuanwo and xyjixyjixyji June 21, 2023 03:06
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jun 21, 2023

Dose my code cause the CI fails?

Seems not related, please ignore.

Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit e2070d0 into apache:main Jun 21, 2023
@infdahai infdahai deleted the remove_all_block branch June 21, 2023 08:01
@PsiACE PsiACE mentioned this pull request Jun 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement remove and remove_all for blocking operator

3 participants