Skip to content

fix(bindings/C): use copy_from_slice instead of from_static in opendal_bytes#2473

Merged
Xuanwo merged 2 commits intoapache:mainfrom
xyjixyjixyji:fix_opendal_bytes_into
Jun 16, 2023
Merged

fix(bindings/C): use copy_from_slice instead of from_static in opendal_bytes#2473
Xuanwo merged 2 commits intoapache:mainfrom
xyjixyjixyji:fix_opendal_bytes_into

Conversation

@xyjixyjixyji
Copy link
Copy Markdown
Contributor

@xyjixyjixyji xyjixyjixyji commented Jun 16, 2023

Also fix #2471

Signed-off-by: Ji-Xinyou <jerryji0414@outlook.com>
@github-actions github-actions Bot added the releases-note/fix The PR fixes a bug or has a title that begins with "fix" label Jun 16, 2023
@xyjixyjixyji
Copy link
Copy Markdown
Contributor Author

I am not seeing why zig ci is missing

@kassane
Copy link
Copy Markdown
Contributor

kassane commented Jun 16, 2023

I am not seeing why zig ci is missing

Missing add libopendal_c path on $PATH or $LD_LIBRARY_PATH to run zig test.

--- edit

Or staticlib #2471 (comment)

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit 2e96c85 into apache:main Jun 16, 2023
@PsiACE PsiACE mentioned this pull request Jun 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/fix The PR fixes a bug or has a title that begins with "fix"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zig Binding doesn't work with static libopendal_c

3 participants