Skip to content

fix(bindings/swift): reorg the package to correct its name#2479

Merged
Xuanwo merged 1 commit intoapache:mainfrom
unixzii:fix-swift-package-structure
Jun 18, 2023
Merged

fix(bindings/swift): reorg the package to correct its name#2479
Xuanwo merged 1 commit intoapache:mainfrom
unixzii:fix-swift-package-structure

Conversation

@unixzii
Copy link
Copy Markdown
Contributor

@unixzii unixzii commented Jun 17, 2023

Swift packages take the name of their enclosing directories as the package name. Users want to use OpenDAL to refer to this package, instead of swift currently.

To do so, we need to put the package contents into a subdirectory named OpenDAL.

This PR also fixes some other minor issues:

  • Use absolute path in linker options.
  • Remove unused rule commands in Makefile.

@github-actions github-actions Bot added the releases-note/fix The PR fixes a bug or has a title that begins with "fix" label Jun 17, 2023
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 95e7a19 into apache:main Jun 18, 2023
@unixzii unixzii mentioned this pull request Jun 18, 2023
6 tasks
@PsiACE PsiACE mentioned this pull request Jun 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/fix The PR fixes a bug or has a title that begins with "fix"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants