Skip to content

feat(bindings/dotnet): basic structure#2485

Merged
Xuanwo merged 19 commits intoapache:mainfrom
tisonkun:csharp-bindings
Jun 18, 2023
Merged

feat(bindings/dotnet): basic structure#2485
Xuanwo merged 19 commits intoapache:mainfrom
tisonkun:csharp-bindings

Conversation

@tisonkun
Copy link
Copy Markdown
Member

This refers to #2428.

You can run with -

./build.py --classifier osx-aarch_64
dotnet test 

tisonkun added 14 commits June 18, 2023 12:03
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jun 18, 2023
Comment thread bindings/dotnet/src/lib.rs Outdated
Comment thread bindings/dotnet/src/lib.rs
Comment thread bindings/dotnet/build.py
Comment thread bindings/dotnet/DotOpenDAL/DotOpenDAL.csproj
tisonkun added 2 commits June 18, 2023 17:16
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun mentioned this pull request Jun 18, 2023
Signed-off-by: tison <wander4096@gmail.com>
Comment thread Cargo.toml
Comment thread bindings/dotnet/Cargo.toml Outdated
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jun 18, 2023

Mostly LGTM. Perhaps we can merge this pull request first and then polish it?

Comment thread bindings/dotnet/src/lib.rs
@tisonkun
Copy link
Copy Markdown
Member Author

Mostly LGTM. Perhaps we can merge this pull request first and then polish it?

Yes. Two major improvement should be done are -

  1. Marshalling and Unmarshalling struct (maybe including strings);
  2. Building and distributing (via NuGet).

References are provided in the tracking issue, while I may not be able to find some time dig into it until the next month.

Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit eead5d2 into apache:main Jun 18, 2023
@PsiACE PsiACE mentioned this pull request Jun 27, 2023
3 tasks
@tisonkun tisonkun deleted the csharp-bindings branch September 27, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants