Skip to content

feat(bindings/haskell): support stat#2504

Merged
Xuanwo merged 4 commits intoapache:mainfrom
silver-ymz:feat/haskell-stat
Jun 21, 2023
Merged

feat(bindings/haskell): support stat#2504
Xuanwo merged 4 commits intoapache:mainfrom
silver-ymz:feat/haskell-stat

Conversation

@silver-ymz
Copy link
Copy Markdown
Member

Update:

  • export Metadata, BytesContentRange, EntryMode
  • support stat for haskell bindings

The memory service only supports some metadata. Some parts of metadata, such as cache control, last modified time cannot be covered for testing. Should we concern about it?

Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jun 21, 2023
Comment thread bindings/haskell/haskell-src/OpenDAL.hs Outdated
Comment thread bindings/haskell/haskell-src/OpenDAL.hs Outdated
Comment thread bindings/haskell/haskell-src/OpenDAL.hs
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jun 21, 2023

The memory service only supports some metadata. Some parts of metadata, such as cache control, last modified time cannot be covered for testing. Should we concern about it?

That's Ok. There is no services that provide all metadata.

Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Comment thread bindings/haskell/haskell-src/OpenDAL.hs Outdated
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xuanwo Xuanwo merged commit b50d7f0 into apache:main Jun 21, 2023
@silver-ymz silver-ymz deleted the feat/haskell-stat branch June 21, 2023 08:15
@PsiACE PsiACE mentioned this pull request Jun 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants