Skip to content

feat(services/redb): support redb service#2526

Merged
Xuanwo merged 9 commits intoapache:mainfrom
oowl:feat/service/redb
Jun 25, 2023
Merged

feat(services/redb): support redb service#2526
Xuanwo merged 9 commits intoapache:mainfrom
oowl:feat/service/redb

Conversation

@oowl
Copy link
Copy Markdown
Member

@oowl oowl commented Jun 24, 2023

introduce new redb service #2524

@oowl oowl marked this pull request as draft June 24, 2023 17:16
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jun 24, 2023
@oowl oowl force-pushed the feat/service/redb branch from 4c228ef to d196a3c Compare June 24, 2023 17:43
Comment thread core/Cargo.toml Outdated
Comment thread core/src/services/redb/backend.rs Outdated
Comment thread core/src/services/redb/backend.rs Outdated
oowl added 4 commits June 25, 2023 23:05
Signed-off-by: owl <ouyangjun1999@gmail.com>
Signed-off-by: owl <ouyangjun1999@gmail.com>
Signed-off-by: owl <ouyangjun1999@gmail.com>
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl oowl force-pushed the feat/service/redb branch from a3a66b1 to d4227cc Compare June 25, 2023 15:06
oowl added 4 commits June 25, 2023 23:14
Signed-off-by: owl <ouyangjun1999@gmail.com>
Signed-off-by: owl <ouyangjun1999@gmail.com>
Signed-off-by: owl <ouyangjun1999@gmail.com>
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl oowl marked this pull request as ready for review June 25, 2023 16:19
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jun 25, 2023

Sorry for the CI failure, fixed in #2534

@oowl
Copy link
Copy Markdown
Member Author

oowl commented Jun 25, 2023

@Xuanwo https://github.com/apache/incubator-opendal/actions/runs/5370716502/jobs/9743000170?pr=2526 and this error, it seems we are using old MSRV version.

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jun 25, 2023

@Xuanwo https://github.com/apache/incubator-opendal/actions/runs/5370716502/jobs/9743000170?pr=2526 and this error, it seems we are using old MSRV version.

Please remove redb from default feature. It's required that opendal with default feature must work on MSRV.

Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl
Copy link
Copy Markdown
Member Author

oowl commented Jun 25, 2023

waiting for #2534 merged and rebase for fix CI failed.

Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 65898d3 into apache:main Jun 25, 2023
@PsiACE PsiACE mentioned this pull request Jun 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants