Skip to content

feat(layers): support await_tree instrument#2623

Merged
Xuanwo merged 7 commits intoapache:mainfrom
oowl:feat/instrument_await
Jul 26, 2023
Merged

feat(layers): support await_tree instrument#2623
Xuanwo merged 7 commits intoapache:mainfrom
oowl:feat/instrument_await

Conversation

@oowl
Copy link
Copy Markdown
Member

@oowl oowl commented Jul 12, 2023

No description provided.

@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jul 12, 2023
@oowl
Copy link
Copy Markdown
Member Author

oowl commented Jul 12, 2023

I am not sure if I have the right understanding for #2616 that I need to add instrument_await message in all service future await function call ?

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jul 13, 2023

Hi, I apologize for not being clear in the previous issue. Our requirement is to create a new layer instead of modifying the existing code. I have left a new comment on this matter at #2616 (comment) which should provide more clarity and assistance.

@oowl oowl marked this pull request as draft July 13, 2023 05:03
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl oowl force-pushed the feat/instrument_await branch from 6262dec to 480d931 Compare July 25, 2023 14:03
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl oowl marked this pull request as ready for review July 25, 2023 14:04
oowl added 3 commits July 25, 2023 22:35
Signed-off-by: owl <ouyangjun1999@gmail.com>
Signed-off-by: owl <ouyangjun1999@gmail.com>
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl oowl changed the title feat(core): support await_tree instrument feat(layers): support await_tree instrument Jul 25, 2023
@oowl
Copy link
Copy Markdown
Member Author

oowl commented Jul 25, 2023

Hi @Xuanwo , I have impl this with layer, Can you help me to take a look?

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jul 25, 2023

Hi @Xuanwo , I have impl this with layer, Can you help me to take a look?

Thanks! I will take a look tomorrow.

Comment thread core/src/layers/await_tree.rs Outdated
Comment thread core/src/layers/await_tree.rs Outdated
oowl added 2 commits July 26, 2023 23:11
Signed-off-by: owl <ouyangjun1999@gmail.com>
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl oowl requested a review from Xuanwo July 26, 2023 16:15
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants