Skip to content

feat(services/persy): add a basic persy service impl#2648

Merged
Xuanwo merged 9 commits intoapache:mainfrom
PsiACE:service-persy
Jul 16, 2023
Merged

feat(services/persy): add a basic persy service impl#2648
Xuanwo merged 9 commits intoapache:mainfrom
PsiACE:service-persy

Conversation

@PsiACE
Copy link
Copy Markdown
Member

@PsiACE PsiACE commented Jul 16, 2023

This PR has initially implemented support for the persy backend, and added corresponding CI and documentation.

# persy
OPENDAL_PERSY_TEST=false
## That path to the persy data file. The directory in the path must already exist.
OPENDAL_PERSY_DATAFILE=/tmp/opendal/test.persy
OPENDAL_PERSY_SEGMENT=data
OPENDAL_PERSY_INDEX=index

Fixes: #2522

PsiACE added 6 commits July 16, 2023 13:27
@PsiACE
feat(services/persy): add a basic persy service impl
2bc5a61 
Signed-off-by: Chojan Shang <psiace@apache.org>
@PsiACE
feat(services/persy): add index to record
7e181fc 
Signed-off-by: Chojan Shang <psiace@apache.org>
@PsiACE
docs(services/persy): fix example
d6b09aa 
Signed-off-by: Chojan Shang <psiace@apache.org>
@PsiACE
refactor(services/persy): handle init logic
cd6477a 
Signed-off-by: Chojan Shang <psiace@apache.org>
@PsiACE
docs(services/persy): add persy item
c93f5e3 
Signed-off-by: Chojan Shang <psiace@apache.org>
@PsiACE
chore(services/persy): add persy ci
f5cdcdd 
Signed-off-by: Chojan Shang <psiace@apache.org>
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jul 16, 2023
@PsiACE
chore: cargo fmt
0c01416 
Signed-off-by: Chojan Shang <psiace@apache.org>
@PsiACE PsiACE requested a review from suyanhanx July 16, 2023 05:53
@PsiACE
Copy link
Copy Markdown
Member Author

PsiACE commented Jul 16, 2023

also cc @Anakin100100 , sorry for the delay, but perhaps you would be willing to help review.

suyanhanx
suyanhanx reviewed Jul 16, 2023
View reviewed changes
Comment thread .github/workflows/service_test_persy.yml Outdated
@PsiACE
chore(ci): remove j=1
c4dfb4b 
Signed-off-by: Chojan Shang <psiace@apache.org>
Xuanwo
Xuanwo reviewed Jul 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other LGTM

Comment thread core/src/services/persy/backend.rs Outdated
Comment thread core/src/services/persy/backend.rs
Comment thread core/src/services/persy/backend.rs Outdated
@PsiACE
chore: fix comments style
9246e8f 
Signed-off-by: Chojan Shang <psiace@apache.org>
Xuanwo
Xuanwo approved these changes Jul 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 7803c41 into apache:main Jul 16, 2023
@PsiACE PsiACE deleted the service-persy branch July 16, 2023 18:17
@oowl oowl mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suyanhanx suyanhanx suyanhanx left review comments

@Xuanwo Xuanwo Xuanwo approved these changes

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees

No one assigned

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add new service support: persy

3 participants

@PsiACE @Xuanwo @suyanhanx