Skip to content

feat(s3): Use us-east-1 while head bucket returns 403 without X-Amz-Bucket-Region #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xuanwo merged 2 commits into from
Jul 20, 2023
Merged

feat(s3): Use us-east-1 while head bucket returns 403 without X-Amz-Bucket-Region #2677

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b27204
s3 head with no X-Amz-Bucket-Region , using us-east-1 region as default
john8628 Jul 20, 2023
479b103
fix cargo fmt
john8628 Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/services/s3/backend.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,14 +619,15 @@ impl S3Builder {
);

match res.status() {
StatusCode::OK | StatusCode::FORBIDDEN | StatusCode::MOVED_PERMANENTLY => {
StatusCode::OK | StatusCode::MOVED_PERMANENTLY => {
let region = res.headers().get("x-amz-bucket-region")?;
if let Ok(regin) = region.to_str() {
Some(regin.to_string())
} else {
None
}
}
StatusCode::FORBIDDEN => Some("us-east-1".to_string()),
Comment thread
Xuanwo marked this conversation as resolved.
// Unexpected status code
_ => None,
}
Expand Down