Skip to content

feat(services/s3): Add assume role support#2687

Merged
Xuanwo merged 1 commit intomainfrom
feat-assume-role
Jul 23, 2023
Merged

feat(services/s3): Add assume role support#2687
Xuanwo merged 1 commit intomainfrom
feat-assume-role

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented Jul 23, 2023

I know this PR is complex, but this is how AWS works.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from PsiACE as a code owner July 23, 2023 08:07
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jul 23, 2023
@Xuanwo Xuanwo requested review from ClSlaid and suyanhanx July 23, 2023 08:21
Copy link
Copy Markdown
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@suyanhanx
Copy link
Copy Markdown
Member

May we add a test job for it?

@Xuanwo Xuanwo merged commit 8b9aef1 into main Jul 23, 2023
@Xuanwo Xuanwo deleted the feat-assume-role branch July 23, 2023 08:23
@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Jul 23, 2023

May we add a test job for it?

Tracked at #2690

@oowl oowl mentioned this pull request Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants