Skip to content

refactor(raw/oio): Reorganize to allow adding more features#2698

Merged
Xuanwo merged 11 commits intomainfrom
oio-reorg
Jul 24, 2023
Merged

refactor(raw/oio): Reorganize to allow adding more features#2698
Xuanwo merged 11 commits intomainfrom
oio-reorg

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented Jul 24, 2023 •
edited by suyanhanx
Loading

Reorganize the raw/oio to allow adding more features

This PR introduces some break changes, including some raw APIs' renaming. No public API changes.

Xuanwo added 9 commits July 24, 2023 11:44
@Xuanwo
Cleanup use
78e4125 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Move append
f59978b 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Move reader
0c550d6 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
More more convert API
172fc79 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Renaming
f239b16 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
polish
ae4dd1a 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Add stream
b958c3b 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Add page
c35eac5 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
move write
4fbdfd7 
Signed-off-by: Xuanwo <github@xuanwo.io>
@github-actions github-actions Bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Jul 24, 2023
Xuanwo added 2 commits July 24, 2023 14:16
@Xuanwo
FIx typo
80acfd4 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Merge branch 'main' into oio-reorg
8f65e68
@Xuanwo Xuanwo changed the title refactor(raw/oio): Reorganize the raw/oio to allow adding more features refactor(raw/oio): Reorganize to allow adding more features Jul 24, 2023
suyanhanx
suyanhanx approved these changes Jul 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please update the PR's desc for more details.

@Xuanwo Xuanwo merged commit c00f0fd into main Jul 24, 2023
@Xuanwo Xuanwo deleted the oio-reorg branch July 24, 2023 06:30
@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Jul 24, 2023

LGTM. Please update the PR's desc for more details.

more details like?

@suyanhanx
Copy link
Copy Markdown
Member

suyanhanx commented Jul 24, 2023

Besides the title, I haven't seen any other explanations or documentation. Could you please provide more information about your changes and intentions? Since there seems to be a lot of modification, it would help the reader better understand this PR and help the release manager organize the changelog.

@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Jul 24, 2023

Besides the title, I haven't seen any other explanations or documentation. Could you please provide more information about your changes and intentions? Since there seems to be a lot of modification, it would help the reader better understand this PR and help the release manager organize the changelog.

Just re-org and some naming style polish, no other changes.

@suyanhanx
Copy link
Copy Markdown
Member

suyanhanx commented Jul 24, 2023

Just re-org and some naming style polish, no other changes.

Well, these changes introduce some break changes, it would be best to mention that. 🤔

@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Jul 24, 2023

Well, these changes introduce some break changes, it would be best to mention that.

Yes, you are right. This API adds breaking changes for raw APIs (no public API changed).

@oowl oowl mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@silver-ymz silver-ymz Awaiting requested review from silver-ymz

Assignees

No one assigned

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Xuanwo @suyanhanx