feat(oio): Add MultipartUploadWrite to easier the work for Writer#2699
feat(oio): Add MultipartUploadWrite to easier the work for Writer#2699
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
suyanhanx
left a comment
There was a problem hiding this comment.
Mostly LGTM.
But for some services like Google Drive, they need position to indicate where to continue to write. We could count and record the sizes we uploaded, then we can also get the position.
This concern is invalid because only services such as S3 and OSS, which have a multipart upload API, can implement this feature. Other services like fs, google drive are not covered (maybe will have their own abstraction). |
Co-authored-by: Suyan <suyanhanx@gmail.com>
😯 Ok. |
This PR will add
MultipartUploadWriteto easier the work of implementingWriter.It's an internal API that users can't use directly. We add this to simplify the work to implement
Writerfor services like s3, cos and oss. And align the behavior of buffering and available options.This PR just migrated the implement of
s3and we will start a migrate issue for other services.