Skip to content

feat(test): add fuzz target for writer#2706

Merged
Xuanwo merged 5 commits intoapache:mainfrom
dqhl76:fuzz-writer
Jul 25, 2023
Merged

feat(test): add fuzz target for writer#2706
Xuanwo merged 5 commits intoapache:mainfrom
dqhl76:fuzz-writer

Conversation

@dqhl76
Copy link
Copy Markdown
Member

@dqhl76 dqhl76 commented Jul 24, 2023

part of: #2551

also split reader and range reader, ref: #2609 (comment)

dqhl76 added 2 commits July 24, 2023 09:55
Signed-off-by: dqhl76 <dqhl76@gmail.com>
Signed-off-by: dqhl76 <dqhl76@gmail.com>
@dqhl76 dqhl76 requested a review from Xuanwo as a code owner July 24, 2023 09:49
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jul 24, 2023
Signed-off-by: dqhl76 <dqhl76@gmail.com>
@dqhl76 dqhl76 changed the title feat: add fuzz target for writer feat(test): add fuzz target for writer Jul 24, 2023
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM!

Comment thread core/fuzz/fuzz_reader.rs Outdated
@dqhl76 dqhl76 marked this pull request as draft July 24, 2023 10:13
Signed-off-by: dqhl76 <dqhl76@gmail.com>
@dqhl76 dqhl76 marked this pull request as ready for review July 25, 2023 01:46
@dqhl76
Copy link
Copy Markdown
Member Author

dqhl76 commented Jul 25, 2023

I reviewed libfuzzer's guide. It request us to minimize the fuzz target. So I split range reader to a individual fuzz target.
https://llvm.org/docs/LibFuzzer.html#id23

@dqhl76 dqhl76 requested a review from Xuanwo July 25, 2023 01:57
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xuanwo Xuanwo merged commit 007565b into apache:main Jul 25, 2023
@oowl oowl mentioned this pull request Jul 28, 2023
@dqhl76 dqhl76 deleted the fuzz-writer branch August 3, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants