Skip to content

feat: cos multipart uploads write#2712

Merged
Xuanwo merged 2 commits intoapache:mainfrom
parkma99:feat/impl_cos_multipart_uploads_write
Jul 26, 2023
Merged

feat: cos multipart uploads write#2712
Xuanwo merged 2 commits intoapache:mainfrom
parkma99:feat/impl_cos_multipart_uploads_write

Conversation

@parkma99
Copy link
Copy Markdown
Contributor

close #2701

@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jul 25, 2023
@parkma99
Copy link
Copy Markdown
Contributor Author

I am confusing how to test?

Comment thread core/src/services/cos/writer.rs Outdated
Comment thread core/src/services/cos/core.rs
@parkma99 parkma99 marked this pull request as ready for review July 26, 2023 02:34
@parkma99 parkma99 requested a review from Xuanwo as a code owner July 26, 2023 02:34
@oowl
Copy link
Copy Markdown
Member

oowl commented Jul 26, 2023

I am confusing how to test?

If you enable the right flag in https://github.com/apache/incubator-opendal/blob/main/core/src/services/cos/backend.rs#L282, All tests will start.

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jul 26, 2023

I am confusing how to test?

You can't run cos integration tests due to GitHub's limitations in this PR. Because you can't use the secrets we configured.

I will test it later this afternoon.

Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, thanks!

@Xuanwo Xuanwo merged commit 332cdb8 into apache:main Jul 26, 2023
@parkma99 parkma99 deleted the feat/impl_cos_multipart_uploads_write branch July 26, 2023 06:54
@oowl oowl mentioned this pull request Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cos: migrate to multipart uploads write

4 participants