Skip to content

feat: add override_content_type#2734

Merged
Xuanwo merged 2 commits intoapache:mainfrom
G-XD:feat_override_content_type
Jul 31, 2023
Merged

feat: add override_content_type#2734
Xuanwo merged 2 commits intoapache:mainfrom
G-XD:feat_override_content_type

Conversation

@G-XD
Copy link
Copy Markdown
Contributor

@G-XD G-XD commented Jul 31, 2023

fix #2724

@G-XD G-XD requested a review from Xuanwo as a code owner July 31, 2023 02:32
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jul 31, 2023
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jul 31, 2023

error: this function has too many arguments (8/7)
   --> core/src/services/s3/core.rs:242:5
    |
242 | /     pub fn s3_get_object_request(
243 | |         &self,
244 | |         path: &str,
245 | |         range: BytesRange,
...   |
250 | |         if_match: Option<&str>,
251 | |     ) -> Result<Request<AsyncBody>> {
    | |___________________________________^
    |
    = note: `-D clippy::too-many-arguments` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Ooops, maybe we can fix this by passing OpRead instead.

@G-XD
Copy link
Copy Markdown
Contributor Author

G-XD commented Jul 31, 2023

error: this function has too many arguments (8/7)
   --> core/src/services/s3/core.rs:242:5
    |
242 | /     pub fn s3_get_object_request(
243 | |         &self,
244 | |         path: &str,
245 | |         range: BytesRange,
...   |
250 | |         if_match: Option<&str>,
251 | |     ) -> Result<Request<AsyncBody>> {
    | |___________________________________^
    |
    = note: `-D clippy::too-many-arguments` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Ooops, maybe we can fix this by passing OpRead instead.

Done.

Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@Xuanwo Xuanwo merged commit ad7952f into apache:main Jul 31, 2023
@oowl oowl mentioned this pull request Jul 31, 2023
@G-XD G-XD deleted the feat_override_content_type branch August 15, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add override_content_type for FuturePresignRead

2 participants