Skip to content

feat: Add postgresql support for OpenDAL#2815

Merged
oowl merged 15 commits intomainfrom
add-pg-support
Aug 9, 2023
Merged

feat: Add postgresql support for OpenDAL#2815
oowl merged 15 commits intomainfrom
add-pg-support

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented Aug 8, 2023

This PR will add postgresql support for OpenDAL.


OHHHHHHH, why? It doesn't make sense to add SQL support in OpenDAL!

You are right. OpenDAL is designed for accessing unstructured data like local fs and s3. And database like postgresql is not good for such use cases. But it doesn't mean we can't do this.

We can store some small (for example, 4KiB) data in database in quick and easy way! We don't need to worry about mysql, pg, clickhouse, xxxdb anymore: use opendal and write data.

Maybe, I'm not convinced and still believe it's useless.

That's Ok. OpenDAL's design makes sure that adding a new service like pg won't affect your existing features at all. Postgresql will under services-postgresql feature and only users who enable this feature will need those code.

So, What's the performance?

We don't know about it so far. This PR just a start, we will try to do some bench to have a general idea about it's perf.

What's next?

I will add integration test to make this service works. And than we can try to add MySQL, SurrealDB and other dbs.

My current interest is to add databend support so that I can run databend on databend (aha, this is really useless, but funny)!

Xuanwo added 2 commits August 8, 2023 14:36
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from PsiACE as a code owner August 8, 2023 14:37
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Aug 8, 2023
@Xuanwo Xuanwo marked this pull request as draft August 8, 2023 14:38
@PsiACE
Copy link
Copy Markdown
Member

PsiACE commented Aug 8, 2023

It sounds a bit crazy, but why not :)

Xuanwo added 10 commits August 9, 2023 15:47
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@oowl
Copy link
Copy Markdown
Member

oowl commented Aug 9, 2023

It's a really really crazy idea! Next, Maybe we need to build OpenDAL on SQLite!

@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Aug 9, 2023

It's a really really crazy idea! Next, Maybe we need to build OpenDAL on SQLite!

Ok, let's expand OpenDAL to more open areas!

Xuanwo added 2 commits August 9, 2023 17:15
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo marked this pull request as ready for review August 9, 2023 09:27
@Xuanwo Xuanwo requested a review from oowl as a code owner August 9, 2023 09:27
Copy link
Copy Markdown
Member

@silver-ymz silver-ymz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Copy Markdown
Member

@oowl oowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oowl oowl merged commit 66f98cd into main Aug 9, 2023
@oowl oowl deleted the add-pg-support branch August 9, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants