feat(services/azblob): Rewrite the method signatures using OpWrite#3068
Merged
Xuanwo merged 2 commits intoapache:mainfrom Sep 14, 2023
Merged
feat(services/azblob): Rewrite the method signatures using OpWrite#3068Xuanwo merged 2 commits intoapache:mainfrom
Xuanwo merged 2 commits intoapache:mainfrom
Conversation
dc9e2fc to
2e29fbe
Compare
13 tasks
Xuanwo
approved these changes
Sep 14, 2023
Member
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you very much! By the way, I noticed that azblob_get_blob from azblob could also be refactored by OpRead. Maybe you would be interested in sending a pull request as well?
Contributor
Author
Wow, that's my miss. should I continue to push to this PR? |
Member
You can start a new PR ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Respect issue: #3064 .
Rewrote the service
azblob.