Skip to content

feat(services/azblob): Rewrite the method signatures using OpWrite#3068

Merged
Xuanwo merged 2 commits intoapache:mainfrom
acehinnnqru:feat/rewrite-azblob-methods
Sep 14, 2023
Merged

feat(services/azblob): Rewrite the method signatures using OpWrite#3068
Xuanwo merged 2 commits intoapache:mainfrom
acehinnnqru:feat/rewrite-azblob-methods

Conversation

@acehinnnqru
Copy link
Copy Markdown
Contributor

Respect issue: #3064 .

Rewrote the service azblob.

@acehinnnqru acehinnnqru requested a review from Xuanwo as a code owner September 14, 2023 13:08
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Sep 14, 2023
@acehinnnqru acehinnnqru force-pushed the feat/rewrite-azblob-methods branch from dc9e2fc to 2e29fbe Compare September 14, 2023 13:11
@acehinnnqru acehinnnqru changed the title feat(services/azblob): Rewrite the method signatures using OpWrite feat(services/azblob)!: Rewrite the method signatures using OpWrite Sep 14, 2023
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM, thanks a lot!

Comment thread core/src/services/azblob/backend.rs Outdated
@Xuanwo Xuanwo changed the title feat(services/azblob)!: Rewrite the method signatures using OpWrite feat(services/azblob): Rewrite the method signatures using OpWrite Sep 14, 2023
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! By the way, I noticed that azblob_get_blob from azblob could also be refactored by OpRead. Maybe you would be interested in sending a pull request as well?

@acehinnnqru
Copy link
Copy Markdown
Contributor Author

Thank you very much! By the way, I noticed that azblob_get_blob from azblob could also be refactored by OpRead. Maybe you would be interested in sending a pull request as well?

Wow, that's my miss. should I continue to push to this PR?

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Sep 14, 2023

should I continue to push to this PR?

You can start a new PR ❤️

@Xuanwo Xuanwo merged commit 6187b6d into apache:main Sep 14, 2023
@acehinnnqru acehinnnqru deleted the feat/rewrite-azblob-methods branch September 14, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants