Skip to content

feat(services/cos): Rewrite the method signatures using OpWrite#3070

Merged
Xuanwo merged 2 commits intoapache:mainfrom
acehinnnqru:feat/rewrite-cos-methods
Sep 14, 2023
Merged

feat(services/cos): Rewrite the method signatures using OpWrite#3070
Xuanwo merged 2 commits intoapache:mainfrom
acehinnnqru:feat/rewrite-cos-methods

Conversation

@acehinnnqru
Copy link
Copy Markdown
Contributor

Respect the cos part of this issue: #3064 .

@acehinnnqru acehinnnqru requested a review from Xuanwo as a code owner September 14, 2023 13:53
@github-actions github-actions Bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Sep 14, 2023
@Xuanwo Xuanwo changed the title feat(services/cos)!: Rewrite the method signatures using OpWrite feat(services/cos): Rewrite the method signatures using OpWrite Sep 14, 2023
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM, thanks a lot!

Comment thread core/src/services/cos/backend.rs Outdated
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! By the way, I noticed that cos_get_object from cos could also be refactored. Maybe you would be interested in sending a pull request as well?

@Xuanwo Xuanwo merged commit 4ebb69b into apache:main Sep 14, 2023
@acehinnnqru acehinnnqru deleted the feat/rewrite-cos-methods branch September 14, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants